[buddypress-trac] [BuddyPress Trac] #7866: Privacy: Privacy policy integration into registration process

[buddypress-trac]

#7866: Privacy: Privacy policy integration into registration process
--------------------------+---------------------
 Reporter:  boonebgorges  |       Owner:  (none)
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  4.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+---------------------

Comment (by boonebgorges):

 [attachment:7866.diff] is a first implementation.

 I've introduced two new functions:
 - `bp_signup_requires_privacy_policy_acceptance()` defaults to true if a
 published Privacy Policy page exists, but can be filtered
 - `bp_nouveau_signup_privacy_policy_acceptance_section()` breaks the
 building of the checkbox markup into a template tag, to avoid overly-
 complicated error checks etc directly in the template

 The checkbox uses the HTML5 `required` attribute. However, the requirement
 is only forced on the back end if the hidden `signup-privacy-policy-check`
 parameter is present. This is to maintain compatibility with theme
 templates (eg bp-legacy) that don't have the checkbox markup. This means
 it'd be possible to craft a POST payload that bypasses the check. I'm not
 sure of a way around this - any ideas are welcome.

 I'd welcome feedback from @imath or @hnla on whether the markup and code
 organization match what's expected in Nouveau.

 And I'd welcome feedback from anyone on default language, etc. Note that
 the `label` text is hardcoded into the template function, and can be
 changed only by overriding the template or using a language file. I'm not
 sure whether we want this to be more easily customizable.

 I haven't yet done anything for the email footer - this needs a separate
 patch.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7866#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac