[buddypress-trac] [BuddyPress Trac] #7855: Privacy: Suggested privacy policy text

[buddypress-trac]

#7855: Privacy: Suggested privacy policy text
-----------------------------------+---------------------
 Reporter:  boonebgorges           |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  4.0
Component:  Core                   |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+---------------------

Comment (by boonebgorges):

 Thanks for the review, @DJPaul. Initial version is committed.

 > * Use `bp_admin_init` for internal consistency? I know it has no impact.
 > * I think `add_privacy_policy_content()` should use a version comparison
 check, not a `function_exists()`. It's more consistent with what we do
 elsewhere, and when we increase the minimum WP version required, it makes
 searching for now-redundant compatibility blocks much easier.

 I made both changes.

 > * HTML escape all translations.

 The pattern in WP and in other plugins I checked is to sanitize content
 through `wp_kses_post()` when adding via
 `wp_add_privacy_policy_content()`. Escape functions are thus redundant.
 But since our text doesn't contain any HTML, it doesn't hurt, so I added
 the escaping.

 > * Let's double-check if "deleted items are removed from the message
 thread for all recipients" is accurate, re: #7523

 You're right - what I wrote in the patch is incorrect. I've removed it.
 > Wording is great, thank you for your work on this. :)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7855#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac