[buddypress-trac] [BuddyPress Trac] #7936: joinleave_group not working on private Group

[buddypress-trac]

#7936: joinleave_group not working on private Group
--------------------------+---------------------
 Reporter:  ravipatel     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.2.0
Component:  Groups        |     Version:  3.0.0
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+---------------------

Comment (by dcavins):

 Hi Boone-

 Thanks for looking into this. I see what you mean--the nonce check fails
 because we're encoding different strings for different cases.

 We later added the ability of site admins to basically do anything (@r-a-y
 caught some issues where old behavior for admins wasn't carrying through),
 but I was of the understanding that site admins were allowed to join
 private groups without requesting membership.

 If that's the case, I'm wondering if this is a good opportunity to fix the
 button, because a site admin is allowed join any group at will. So the
 other way to mesh the front- and back-end request is to change the button
 to be a Join Group button. I've attached a patch that makes the front end
 display match our permissions logic more closely.

 If that's not the case, then another way to fix the issue if to change the
 permissions so that site admins have to request membership in the
 permission structure.

 In either case, I think your changes should be rolled in, because they
 make the logic clearer. Also, the logic as it exists would only allow
 invitation acceptance to happen for private groups, which can't be right.
 (I've been using invite anyone for so long I'll admit I'm not 100% sure
 how vanilla invites work without testing them.)

 Thanks again for poking at this. I'm going to think about it some more,
 and if we can agree on the site admin permission thing, I'll need to fix
 that in at least one place.

 Thanks!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7936#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac