[buddypress-trac] [BuddyPress Trac] #7926: Automated linting for PHP versions
buddypress-trac
noreply at wordpress.org
Tue Jul 24 01:42:31 UTC 2018
#7926: Automated linting for PHP versions
------------------------------+---------------------
Reporter: boonebgorges | Owner: netweb
Type: enhancement | Status: new
Priority: normal | Milestone: 4.0
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+---------------------
Changes (by netweb):
* keywords: 2nd-opinion has-patch => has-patch commit
Comment:
Replying to [comment:2 boonebgorges]:
> [attachment:"7926.grunt.diff"] is maybe smarter - it uses a grunt task
for linting, so everything's centralized.
Works for me +1
> This approach could use the eyes of @netweb, as it does things to my
local npm-shrinkwrap that I don't understand.
I've added a `.npmrc` file to [attachment:"7926.grunt.2.diff"] that will
now use `~` (tilde) as the default semver prefix instead of the default
`^` (caret) and also updated the `npm-shrinkwrap.json` file with all the
required changes in this ticket. WordPress itself has also made this
switch, or if it hasn't its just because it hasn't been committed to
trunk.
Not a blocker for this ticket but I'm wondering if the `grunt phplint` ask
should also operate on Travis CI accross multiple PHP versions? 💥
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7926#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list