[buddypress-trac] [BuddyPress Trac] #7665: Date Picker - make field selection names clearer

[buddypress-trac]

#7665: Date Picker - make field selection names clearer
-------------------------+-----------------------
 Reporter:  Venutius     |       Owner:  DJPaul
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  3.0
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+-----------------------

Comment (by DJPaul):

 I asked @rianrietveld about the select/option element question, in the
 context of screen readers: "If the text of the label and the first option
 is the same, (VoiceOver) only announces it once. Leaves you with the
 possibility that people can select and submit the first option." I was
 also told that "hiding the label and using the first item as
 placeholder/label is in fact a hack", so this is a good opportunity to
 correct this.

 I think using block elements here is going to be too big a change for most
 themes to support, so displaying them inline (albeit with the label now
 showing) is least invasive. I also prefer how it looks. I have run with
 @mercime's patch and made 7665-2.patch which adds CSS fixes for the above.

 Outstanding tasks for feedback:

 1) Do we change --- to Day, Month, Year (on each label appropriately), so
 we think the VoiceOver screen reader won't say (based on above screenshot)
 "Date of Birth, Day, dash dash dash" -> "Date of Birth, Day".

 ...or...

 Do we come up with a phrase to replace ---, perhaps "Unset" (needs to be
 something short, but basically "No year selected"), so the VoiceOver might
 go "Date of Birthday, Day, Unset" or "Date of Birthday, Day, No year
 selected".

 I prefer the latter though we'd have to use a very short text otherwise we
 will force the width of the select boxes to grow -- typically German is my
 go-to example because its words tend to be very long).

 2) I'm not sure "bp-datefield" is the best idea of a CSS class here. @hnla
 can I use "inline-label" as a class name or do you have a better idea?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7665#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac