[buddypress-trac] [BuddyPress Trac] #7656: Update `bp_new_group_invite_friend_list` for new $args to support full list markup

buddypress-trac noreply at wordpress.org
Wed Jan 24 10:24:23 UTC 2018


#7656: Update `bp_new_group_invite_friend_list` for new $args to support full list
markup
-------------------------+------------------
 Reporter:  hnla         |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.0
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------

Comment (by DJPaul):

 The indentation for `$allowed` is incorrect, but that aside, I don't see
 much point to KSES this now we've explored this more; user-supplied data
 will not be directly passed to this function. Bigger chance that it annoys
 a developer trying to some crazy customisation, especially as `$allowed`
 element is hardcoded.

 I know I suggested looking at KSES originally and you weren't sure :) but
 please remember this is as much code review as it is a  collaborative
 technical discussion, and that I can talk rubbish with the best of them.
 :)

 I think the couple of new arguments and the change to `$retval` is all we
 need!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7656#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list