[buddypress-trac] [BuddyPress Trac] #7659: Subnav menu with 'user_has_access' set to false should redirect but doesn't

[buddypress-trac]

#7659: Subnav menu with 'user_has_access' set to false should redirect but doesn't
--------------------------+-------------------
 Reporter:  r-a-y         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  3.0
Component:  Core          |    Version:  2.6.0
 Severity:  normal        |   Keywords:
--------------------------+-------------------
 In #6534, we refactored the way we register menu items with the BP
 Navigation API.

 Unfortunately, we broke functionality to redirect subnav menu items with
 `user_has_access` set to false.

 Example code:

 {{{#!php
 <?php
 add_action( 'bp_setup_nav', function() {
         bp_core_new_nav_item( array(
                 'name'                    => 'Secret Stash',
                 'slug'                    => 'secret-stash',
                 'screen_function'         => 'my_secret_stash_screen',
                 'default_subnav_slug'     => 'my-stash',
                 'show_for_displayed_user' => false,
         ) );

         bp_core_new_subnav_item( array(
                 'name'            => 'My Stash',
                 'slug'            => 'my-stash',
                 'parent_url'      => trailingslashit(
 bp_displayed_user_domain() . 'secret-stash' ),
                 'parent_slug'     => 'secret-stash',
                 'user_has_access' => bp_is_my_profile(),
                 'no_access_url'   => is_user_logged_in() ?
 bp_loggedin_user_domain() : '',
                 'screen_function' => 'my_secret_stash_screen'
         ) );
 } );

 function my_secret_stash_screen() {
         add_action( 'bp_template_content', function() {
                 echo "Ssh! It's a secret!";
         } ) ;
         bp_core_load_template( 'members/single/plugins' );
 }
 }}}

 '''Expected behavior:'''
 If you are logged in and you attempt to view another person's stash
 (`example.com/members/ANOTHER-USER/secret-stash/`), you should be
 redirected back to your profile page with an error message.

 If you are logged out and you attempt to view the same URL, you should get
 redirected to login.  On success, you can view your stash.  If you login
 with another account, you get redirected back to your profile page with an
 error message.

 '''Current behavior:'''
 You get a 404 page when you view that URL.

 ----

 '''The problem:'''

 In #6534, we missed a portion of the refactor in
 `bp_core_register_subnav_screen_function()`.

 `$parent_nav` is an array that needs to use the `reset()` function so we
 grab the actual nav object.

 See other areas in `bp-core-buddybar.php` that follows the same pattern:
 https://buddypress.trac.wordpress.org/browser/tags/2.9.2/src/bp-core/bp-
 core-buddybar.php?marks=308-315,506-514,683-686#L308

 Attached patch fixes this up.

 Patch also fixes the redirect message to show up on frontend pages (the
 `mode` portion of the patch) and alters the strings to better reflect what
 is happening (`that` instead of `this`).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7659>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac