[buddypress-trac] [BuddyPress Trac] #7265: uploads dir should filtered for cover images

buddypress-trac noreply at wordpress.org
Fri Feb 16 22:44:06 UTC 2018

#7265: uploads dir should filtered for cover images
 Reporter:  m_uysl                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  3.0
Component:  Core                     |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion needs-testing => has-patch needs-testing


 Thanks @imath ! I'm glad I asked you - I wasn't thinking about the
 `buddypress` directory.

 I like that [attachment:7265.02.patch] tries to keep most of the logic
 running through `BP_Attachment` - it feels wise to have it centralized.
 But I also find it much harder to reason about than
 [attachment:7265.02-alternative.patch], which is (IMO) much more

 I think we might move toward a future where upload path generation happens
 in a more vertical fashion, so that (for example)
 `bp_attachments_uploads_dir_get()` is the ultimate source of truth used
 for the top-level attachment directory, and then everything else builds on
 it (`BP_Attachment->upload_path` etc would use this instead of
 `bp_upload_dir()`, cover images paths would be built this way, etc). This
 is not something that needs to be solved today, though, so I think that
 [attachment:7265.02-alternative.patch] is probably the right tack.

 @rekmla I've spoken with your team about this issue recently - would you
 mind giving [attachment:7265.02-alternative.patch] a look to see if it
 solves the problem for you?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7265#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list