[buddypress-trac] [BuddyPress Trac] #7265: uploads dir should filtered for cover images

buddypress-trac noreply at wordpress.org
Fri Feb 16 17:07:56 UTC 2018

#7265: uploads dir should filtered for cover images
 Reporter:  m_uysl                               |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  3.0
Component:  Core                                 |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-testing  |
Changes (by boonebgorges):

 * keywords:  needs-patch => has-patch 2nd-opinion needs-testing
 * milestone:  Awaiting Contributions => 3.0


 Circling back around to this ticket. [attachment:7265.diff] is a first
 pass at centralizing the filtering of the cover image upload directory.
 This does appear to fix the immediate issue of path filterability; filters
 on `bp_attachments_cover_image_upload_dir` work properly now, without
 breaking uploads.

 @imath - I don't like to ping you about stuff like this, but could I ask
 you to take 5-10 minutes - no more!! - and think about whether it's going
 to cause other problems if we generate cover image upload paths like this,
 outside of the `BP_Attachment_Cover_Image` class? I think that the
 `upload_dir_filter()` method will still work internally, so
 `$this->upload_path` etc ought to be correct - but this is a pretty
 delicate system, so I'm nervous :-D

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7265#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list