[buddypress-trac] [BuddyPress Trac] #7689: Non-standard 'template' loading broken in Nouveau.

buddypress-trac noreply at wordpress.org
Thu Feb 8 16:29:55 UTC 2018

#7689: Non-standard 'template' loading broken in Nouveau.
 Reporter:  boonebgorges             |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  3.0
Component:  Templates                |     Version:
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |
Changes (by boonebgorges):

 * keywords:   => has-patch needs-testing


 [attachment:7689.diff] attempts to fix this by introducing a bit more
 standardization to the way that custom templates are requested via AJAX.
 Before [11821], you would pass a template *path*. I've changed it so that
 you now pass (optionally) a template *label*, which could be
 `group_members`, `group_requests`, `member_notifications`, etc. When the
 AJAX handler sees this `template`, it assumes that this is a special case
 and loads the correct template. If `template` is absent, it loads `$object
 /$object-loop`, as before.

 I think that this change makes the process a little bit easier to reason
 about than introducing more `$object` magic in the AJAX handler. Can I get
 a second set of eyes (and a bit of testing)?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7689#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list