[buddypress-trac] [BuddyPress Trac] #7668: Remove loggedin_user duplicate check for messages_check_thread_access()

[buddypress-trac]

#7668: Remove loggedin_user duplicate check for messages_check_thread_access()
-------------------------+--------------------------
 Reporter:  espellcaste  |       Owner:  espellcaste
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  3.0
Component:  Messages     |     Version:
 Severity:  normal       |  Resolution:  fixed
 Keywords:  has-patch    |
-------------------------+--------------------------
Changes (by espellcaste):

 * owner:   => espellcaste
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"11844"]:
 {{{
 #!CommitTicketReference repository="" revision="11844"
 Remove redundant handling of optional `$user_id` parameter from
 `messages_check_thread_access()`

 On `messages_check_thread_access()`, we are checking if the `$user_id`
 parameter is set. The same check is being done on
 `BP_Messages_Thread::check_access()`.

 So we are keeping only the low level check, instead of both.

 Props DjPaul.

 Fixes #7668
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7668#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac