[buddypress-trac] [BuddyPress Trac] #8028: Javacript updates the Favourite/UnFavorite button incorrectly on Nouveau

[buddypress-trac]

#8028: Javacript updates the Favourite/UnFavorite button incorrectly on Nouveau
--------------------------+-----------------------------
 Reporter:  joncadams     |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Templates     |    Version:  4.1.0
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 I think I found a bug on Nouveau:
 the javascript gives the button a title attribute it did not have
 initially after updating with ajax, and does not update the tooltip as it
 should. to keep things consistent I made the following changes:

 ----

 In **bp-nouveau\js\buddypress-activity.js** on line 464:
 {{{#!php
 $( this ).prop( 'title', response.data.content );
 }}}
 should be:
 {{{#!php
 $( this ).attr( 'data-bp-tooltip', response.data.content );
 }}}

 ----


 In **bp-nouveau\includes\activity\ajax.php** on line 145:
 {{{#!php
 $response = array( 'content' => __( 'Favorite', 'buddypress' ) );
 }}}
 should be:
 {{{#!php
 $response = array( 'content' => __( 'Mark as Favorite', 'buddypress' ) );
 }}}

 ----


 And in **bp-nouveau\includes\activity\template-tags.php** on line 378:
 {{{#!php
 'link_text'        => __( 'Favorite', 'buddypress' ),
 }}}
 should be:
 {{{#!php
 'link_text'        => __( 'Mark as Favorite', 'buddypress' ),
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8028>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac