[buddypress-trac] [BuddyPress Trac] #8026: Default avatar choices show same generated icon in general discussion settings

[buddypress-trac]

#8026: Default avatar choices show same generated icon in general discussion
settings
--------------------------+-----------------------------
 Reporter:  netweblogic   |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 If you go to the Settings > Discussion settings page of WP, you'll notice
 all the avatar icons are the same generated icon according to the setting
 chosen.

 For example, if your site default is Wavatar, all the choices show a
 Wavatar as an example.

 The culprit is around line 653 of bp-core/bp-core-avatars.php

 {{{#!php
                 $default_grav = apply_filters( 'bp_core_avatar_default',
 $default_grav, $params );

                 // Only set default image if 'Gravatar Logo' is not
 requested.
                 if ( 'gravatar_default' !== $default_grav ) {
                         $url_args['d'] = $default_grav;
                 }
 }}}

 This does not respect the
 {{{#!php
 $args['default']
 }}}

 argument provided by WordPress get_avatar() and

 {{{#!php
 $url_args['d']
 }}}

 gets given an incorrect default gravatar for a regular user in the
 settings context.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8026>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac