[buddypress-trac] [BuddyPress Trac] #8012: BP 4.0: Fatal Error re add new members in wp-admin > Groups > Group > Edit

[buddypress-trac]

#8012: BP 4.0: Fatal Error re add new members in wp-admin > Groups > Group > Edit
--------------------------+---------------------
 Reporter:  shanebp       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.1.0
Component:  Core          |     Version:
 Severity:  major         |  Resolution:
 Keywords:  needs-patch   |
--------------------------+---------------------

Comment (by johnjamesjacoby):

 3.diff is based on 2.diff, but suggests the following alterations:

 * Prefer `bp_is_large_install()` over `bp_is_large_network()`. Networks do
 not have user counts, removing a mild naming inaccuracy. (This also
 mirrors what's in bbPress.)
 * Use this new function in 1 extra place (inside
 `bp_blogs_record_existing_blogs()`)
 * Remove the `sites` vs` users` designation. BuddyPress will really only
 ever care about user counts, and has not ever used the `sites` version of
 `wp_is_large_network()`. If it ever does, it will be able to use the core
 function. If BuddyPress needs a count of the number of sites in a network,
 it can rely on the WordPress core queries or functions.
 * Only applies the filters once at the end of the function. The WordPress
 core pattern of having 2 `apply_filters()` calls that do the same thing
 inside the same function, is more confusing than it needs to be, and one
 I'd prefer we not follow in code that is under our influence.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8012#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac