[buddypress-trac] [BuddyPress Trac] #7732: BP-Nouveau: Group Creation Menu issues

buddypress-trac noreply at wordpress.org
Sat Apr 14 09:35:31 UTC 2018


#7732: BP-Nouveau: Group Creation Menu issues
--------------------------+-----------------------
 Reporter:  mercime       |       Owner:  dcavins
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  3.0
Component:  Templates     |     Version:
 Severity:  blocker       |  Resolution:
 Keywords:                |
--------------------------+-----------------------

Comment (by hnla):

 Not disagreeing it's an identical function but as above it's more about
 re-positioning core template functions to a template level where they can
 be easily managed/overloaded.

 I'm not going to argue over this though I haven't the time or energy :)

 my opinion is to use @dcavins two patches, possibly refactor the li
 elements children so we don't generate the links on non link/active steps,
 change the UL to OL and update the styles to account for removed anchors &
 OL element numbering, If we go that route I'll handle the OL change and
 the ruleset updates.

 Or we dump the function, when we have a consensus & commit approach I'll
 step in and handle the OL change and refactoring the rules to be less tied
 to elements and hook on the tab class.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7732#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list