[buddypress-trac] [BuddyPress Trac] #7729: Remove BuddyBar?

[buddypress-trac]

#7729: Remove BuddyBar?
-------------------------+---------------------
 Reporter:  DJPaul       |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.1
Component:  Navigation   |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+---------------------

Comment (by r-a-y):

 > the risk is raised because of the setup_nav() changes you found (unless
 you can very test this next week (before Friday) maybe).

 There is one issue with `01.patch` and that is those that rely on the
 BuddyBar / older `buddypress()->bp_nav` for generating the logged-in
 navigation.

 `01.patch` breaks this unit test:
 https://buddypress.trac.wordpress.org/browser/trunk/tests/phpunit/testcases/routing/core.php

 Since we are removing the BuddyBar, there isn't much of a use-case for
 keeping logged-in navigation.  We also introduced BuddyPress integration
 into "Appearance > Menus" a long time ago as well (#5122), which most
 sites are probably using for menu generation.

 If we want to keep compatibility with older, logged-in navigation, then
 see `02.patch`.

 However, if we're not concerned with the older logged-in navigation, I've
 already tested the patch for all frontend user profile navigation items
 and this still works.

 > Are the functions in bp-core-buddybar.php basically route
 parsing/registration?

 `bp-core-buddybar.php` is poorly named, but that file is critical to user
 nav registration.

 Could be renamed to `bp-core-nav.php` or something like that.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7729#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac