[buddypress-trac] [BuddyPress Trac] #6049: Do not activate user accounts automatically with one click

[buddypress-trac]

#6049: Do not activate user accounts automatically with one click
-------------------------------------+-----------------------
 Reporter:  vimes1984                |       Owner:
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  3.0
Component:  Members                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 [attachment:6049.diff] is a first pass. It does the following:

 * Removes the auto-activation. Visiting `/activate/12345` (or
 `/activate?key=12345` for backward compatibility) prefills the input, and
 you have to click to submit. The logic is in a separate `bp-members-
 actions.php` callback, where I think it makes more sense.
 * Turns the form into a `POST` rather than a `GET`. This requires a small
 bit of back-compat shimming in `bp_members_action_activate_account()` so
 that templates using `method="get"` continue to work.
 * Performs a redirect at the end of a successful activation, so that you
 don't end up at the same `activate/12345` URL (which could result in
 confusing behavior in some cases). This requires passing an `?activated=1`
 param, so the template shows the right stuff.
 * Templates are fixed in bp-legacy and bp-nouveau.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6049#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac