[buddypress-trac] [BuddyPress Trac] #7218: Only load component action and screen code when we're on the component's page
buddypress-trac
noreply at wordpress.org
Thu Nov 16 19:43:00 UTC 2017
#7218: Only load component action and screen code when we're on the component's
page
-----------------------------+-----------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: reopened
Priority: normal | Milestone: 3.0
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch early |
-----------------------------+-----------------------
Comment (by boonebgorges):
Thanks for continuing to pursue this, @r-a-y.
I've reviewed the patches and the end of the conversation above. I think
the approach you've put in the most recent patches feels fine. My
questions in [comment:30 comment:30] were really just questions, and I'm
happy with your judgment here.
The talk about PSR-4 in wp-cli-buddypress is pretty early. It probably
makes sense for the whole team to have a conversation about this, but this
conversation will be complex (what about WP coding standards, for
example?) and may not happen soon. Also, we may decide only to enforce new
naming conventions for new features, like CLI commands or API-related
stuff. So, I'd suggest going with what you've got, which matches our
current conventions.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7218#comment:34>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list