[buddypress-trac] [BuddyPress Trac] #7436: Very slow check_is_friend function

buddypress-trac noreply at wordpress.org
Wed Nov 8 22:55:48 UTC 2017


#7436: Very slow check_is_friend function
--------------------------+------------------
 Reporter:  januzi_pl     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.0
Component:  Friends       |     Version:  2.7
 Severity:  major         |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------

Comment (by dcavins):

 I'm attaching a patch that adds a filter to prevent use of the user bulk
 friendship cache. It adds a lot of complexity to the function, though, so
 I'm of two minds whether we want to support both approaches in the long
 term.

 The patch passes all unit tests (other than the test that verifies that
 the cache is used, ha ha) both in the default setup (use the bulk
 friendship cache), and in the alternate setup (don't use the bulk cache).
 I tested the second option by adding `add_filter(
 'bp_bulk_cache_user_friendships', '__return_false' );` to my test
 installation's `bp-custom.php`. Is there a way to automatically test all
 friendship tests in both situations?

 Thanks for your feedback.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7436#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list