[buddypress-trac] [BuddyPress Trac] #7532: BP_Button needs to update `$parent_element` and `$parent_attr`

buddypress-trac noreply at wordpress.org
Wed May 31 07:12:19 UTC 2017


#7532: BP_Button needs to update `$parent_element` and `$parent_attr`
--------------------------+--------------------
 Reporter:  r-a-y         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.9
Component:  Core          |     Version:  2.8.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by hnla):

 @r-a-y also, and not sure if you read my comments in slack, we need to be
 able to acknowledge in the class what those buttons parent container is
 element wise so we can force $parent_element to 'li' if the $container
 returns 'ul' this is similar to the approach I took in Nouveau arg
 functions where if 'ul' are set them the $parent_element must be a 'li'
 type. Currently plugins might not be aware of args available and if not
 setting $parent_element the default 'div' will be used breaking A ul
 construct.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7532#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list