[buddypress-trac] [BuddyPress Trac] #7469: Adding condition check on page delete

[buddypress-trac]

#7469: Adding condition check on page delete
------------------------------+------------------------------
 Reporter:  raftaar1191       |       Owner:  johnjamesjacoby
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:  2.9
Component:  Core              |     Version:  2.8.2
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------------------
Changes (by johnjamesjacoby):

 * keywords:  has-patch => has-patch commit
 * owner:   => johnjamesjacoby
 * status:  new => reviewing
 * milestone:  2.8.3 => 2.9


Comment:

 Hi @raftaar1191, thanks for the report.

 Every usage of `bp_core_get_directory_page_ids()` assumes an array is
 returned. In addition, each usage has inconsistent type-casting on that
 return value.

 We can (very safely) circumvent this (and potentially other similar
 issues) by ensuring it always returns an array, and removing the
 inconsistent type-casting.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7469#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac