[buddypress-trac] [BuddyPress Trac] #7218: Only load component action and screen code when we're on the component's page
buddypress-trac
noreply at wordpress.org
Thu Jun 15 08:35:05 UTC 2017
#7218: Only load component action and screen code when we're on the component's
page
-------------------------+-----------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: reopened
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+-----------------------
Comment (by boonebgorges):
Thanks for working on this, @r-a-y! I think it's moving in the right
direction.
You opted for a separate class for each router. Any specific reason why?
I'd imagined maybe a single `BP_Activity_Actions` class, with (static?)
methods for each router. This would keep our number of files lower. It
would also prevent us from doing lots of logic inside of a `__construct()`
method, which makes it easier to imagine writing tests for these at some
point in the future.
What do you think? I don't feel strongly about it.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7218#comment:30>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list