[buddypress-trac] [BuddyPress Trac] #7450: Problem deleting comment activities

[buddypress-trac]

#7450: Problem deleting comment activities
--------------------------+---------------------
 Reporter:  Maniou        |       Owner:  r-a-y
     Type:  defect (bug)  |      Status:  closed
 Priority:  highest       |   Milestone:  2.8.3
Component:  Activity      |     Version:  2.8.0
 Severity:  critical      |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by r-a-y):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"11583"]:
 {{{
 #!CommitTicketReference repository="" revision="11583"
 Activity: Fix activity comment deletion when comment ID equals `0`.

 In #7394, non-existent activity ID lookups now default to zero, instead of
 the ID that was passed. For example, `$a = new BP_Activity_Activity( 99
 )`,
 `$a->id` now equals `0` instead of `99`.

 This is logistically correct; however, this raised a bug with
 `bp_activity_delete_comment()` when passing `0` as the comment ID, which
 could potentially delete all activity comments in the database.

 Props Maniou.

 Fixes #7450 (trunk)
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7450#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac