[buddypress-trac] [BuddyPress Trac] #7429: Update and fix all the NPM things

buddypress-trac noreply at wordpress.org
Sun Jun 4 00:26:26 UTC 2017


#7429: Update and fix all the NPM things
------------------------------+---------------------
 Reporter:  netweb            |       Owner:  netweb
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  2.9
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:                    |
------------------------------+---------------------
Changes (by netweb):

 * keywords:  early =>
 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 Replying to [ticket:7429 netweb]:
 > 1. Update out of date packages, see table below
 Fixed via [11565] to [11573] changesets

 > 2.  Update Node engine from 6.6.0 to latest 6.x LTS release 6.9.4 in
 `package.json`

 Fixed via [11574]

 > 3. NPM modules in `package.json` should only use semantic versioning
 `~` ''minor'' versions, rather than `^` ''major'' versions, regardless of
 the `npm-shrinkwrap.json` file this will hopefully remove one potential
 issue, and improve the stability of BPs NodeJS and NPM build tools
 implementation.

 Fixed via  [11565] to [11574] commits where required

 > 4. Manually updating the BuddyPress version in `npm-shrinkwrap.json` is
 a task that shouldn't be performed manually, the `npm-shrinkwrap.json`
 should only be generated and/or regenerated by NPM itself.

 Fixed via [11575]

 >  * Update the codex docs on how to update the `npm-shrinkwrap.json`
 file. Include notes that if using `NPM v4.x to run `npm shrinkwrap` will
 include development dependencies, whereas in NPM 3.x development
 dependencies had to be explicitly included by using `npm shrinkwrap --dev`

 Done, updated codex docs here: https://codex.buddypress.org/prelaunch-
 checklist/#version-bumps-in-dev
 > 5. Maybe add https://github.com/mstuart/grunt-shrinkwrap (depends  on
 pending PRs merging)
 Let's use `package-lock.json` as part of npm v5.x.x, new ticket for this
 coming shortly

 That's everything, marking this ticket now as fixed.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7429#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list