[buddypress-trac] [BuddyPress Trac] #7096: Messages: member page messages are queried for the loggedin user

buddypress-trac noreply at wordpress.org
Thu Jul 13 18:45:21 UTC 2017


#7096: Messages: member page messages are queried for the loggedin user
--------------------------+----------------------
 Reporter:  Offereins     |       Owner:  dcavins
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  2.9
Component:  Messages      |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+----------------------

Comment (by boonebgorges):

 [attachment:7096.2.diff] gives the suggested treatment to the functions
 that output a link that might conceivably be used in a different context:
 `bp_message_thread_view_link()`, `bp_message_thread_delete_link()`,
 `bp_the_message_thread_mark_unread_url()`,
 `bp_the_message_thread_mark_read_url()`.

 URLs that are used for redirects in screen/action functions can be
 hardcoded to reference the displayed user, I think. The same goes for the
 `form_action`.

 I wasn't sure whether to touch notice-related URLs. I think notices can
 appear in any context, even when there's no displayed user. Is there a
 situation where notice-related links should *not* be generated relative to
 the logged-in user? IMO these parts of [11578] should probably be rolled
 back.

 @dcavins Can you please give a sanity check to the above?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7096#comment:30>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list