[buddypress-trac] [BuddyPress Trac] #7565: Multisite signups do not have a WordPress role

[buddypress-trac]

#7565: Multisite signups do not have a WordPress role
--------------------------+-----------------------------
 Reporter:  r-a-y         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Members       |    Version:
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------------
 When a user registers on a multisite install, after the user activates
 their account, that user does not have a WordPress role on the BP root
 blog.

 To duplicate:
 - Set up a multisite install and enable user registration.
 - Go to the BP signup page (example.com/register) and register a new user.
 - Activate the new user.
 - Now, login as an administrator to the root blog's admin dashboard
 "Users" page.
 - You'll notice that the user is not listed because the new user has no
 WordPress role on the root blog.

 The problem is during the activation process, `wpmu_create_user()` (via
 `wpmu_activate_signup()`) does not add a role:
 https://github.com/WordPress/WordPress/blob/4.8-branch/wp-includes/ms-
 functions.php#L1116

 However, we do add a role for single site signups, but not multisite:
 https://buddypress.trac.wordpress.org/browser/tags/2.8.2/src/bp-members
 /bp-members-functions.php?marks=2001-2002#L1991

 Attached patch will add a default role regardless of the WP install after
 activation.  Also includes a unit test.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7565>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac