[buddypress-trac] [BuddyPress Trac] #7423: Group Types Default Pagination Broken

[buddypress-trac]

#7423: Group Types Default Pagination Broken
--------------------------+-----------------------
 Reporter:  reubenlillie  |       Owner:  r-a-y
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  2.8
Component:  Groups        |     Version:  2.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------
Changes (by r-a-y):

 * status:  new => assigned
 * priority:  high => normal
 * owner:   => r-a-y
 * version:  2.7.2 => 2.7
 * milestone:  Future Release => 2.8
 * keywords:  ui-feedback => has-patch


Comment:

 This is a legit bug that only occurs if there is more than one page of
 groups on a group type directory.

 There are two issues:
 1. In the `BP_Groups_Component::setup_globals()` method, we throw a 404
 for group pages that is not a single group page or the group creation
 page.  This meant that the AJAX call was throwing a 404.
 2. Currently, group type directory detection occurs on frontend screens
 only and not during AJAX.  We need to move the group type directory
 detection into the `BP_Groups_Component` class so this can be picked up by
 AJAX.

 Patch fixes this both up.

 Would love to squeeze this in for BP 2.8, since this bug was introduced in
 2.7.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7423#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac