[buddypress-trac] [BuddyPress Trac] #4986: bp_nav_menu avtivity favourit filter selection clash with bbPress favourits

[buddypress-trac]

#4986: bp_nav_menu avtivity favourit filter selection clash with bbPress favourits
--------------------------+-----------------------------
 Reporter:  hnla          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Core          |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------------
Changes (by lakrisgubben):

 * keywords:  needs-patch => has-patch


Comment:

 The problem is that the current implementation of `bp_get_nav_menu_items`
 only checks if the submenu slug is the same as `bp_current_action` which
 leads to false positives if two different components have submenus that
 use the same slug (like favorites). The attached patch fixes this by also
 checking that the parent menu item has the same slug as the current
 component.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4986#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac