[buddypress-trac] [BuddyPress Trac] #7509: BP_PHPMailer needs to set the `Date` header

buddypress-trac noreply at wordpress.org
Thu Apr 20 22:50:43 UTC 2017


#7509: BP_PHPMailer needs to set the `Date` header
--------------------------+-----------------------------
 Reporter:  r-a-y         |      Owner:  DJPaul
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Emails        |    Version:  2.5.0
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------------
 I'm using a long-running script that includes sending email with
 BuddyPress native emails.

 What I'm seeing is the `Date` field is only initialized once during the
 first send.  Subsequent sendouts uses the original date.

 The problem is because BuddyPress uses a static version of PHPMailer:
 https://buddypress.trac.wordpress.org/browser/tags/2.8.2/src/bp-
 core/classes/class-bp-phpmailer.php?marks=28,39,47#L27

 And PHPMailer doesn't set the `Date` field again if one already exists:
 https://github.com/WordPress/WordPress/blob/4.7-branch/wp-includes/class-
 phpmailer.php#L2028

 So subsequent mailouts will be sent out with the wrong date, making new
 emails hard to view in an email client.

 My use-case might be a little specific, but I think it will help if we
 always set the `Date` header so other scripts will not run into the same
 problem as me.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7509>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list