[buddypress-trac] [BuddyPress Trac] #7501: Add "status" parameter to groups_get_groups().

buddypress-trac noreply at wordpress.org
Tue Apr 11 18:09:02 UTC 2017


#7501: Add "status" parameter to groups_get_groups().
-------------------------+------------------------------
 Reporter:  dcavins      |       Owner:  dcavins
     Type:  enhancement  |      Status:  accepted
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Groups       |     Version:  1.6
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------

Comment (by dcavins):

 Replying to [comment:2 r-a-y]:
 > Looks good, but not sure why we would want to support multiple group
 statuses that are delimited by a space.  I would probably remove that and
 just ask for an array from the get-go if one is querying for multiple
 statuses.

 Thanks for your comments, @r-a-y. I was primarily following our other
 input filtering that is self-defense against a variety of input types,
 similarly to how we handle the `group_type` parameter in
 `groups_get_groups()`, which I think was based on how WP does something
 similar in W_Query: https://core.trac.wordpress.org/browser/tags/4.7.3/src
 /wp-includes/class-wp-query.php#L1943

 In any case, I'm OK with accepting the parameter in whatever format is
 preferred by the team for consistency internally.

 Thanks again for taking a look.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7501#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list