[buddypress-trac] [BuddyPress Trac] #3961: Hierarchical groups

buddypress-trac noreply at wordpress.org
Tue Sep 13 15:24:01 UTC 2016


#3961: Hierarchical groups
------------------------------------+-----------------------
 Reporter:  sooskriszta             |       Owner:  dcavins
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.7
Component:  Groups                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by dcavins):

 Hi @boonebgorges- Thanks again for taking the time to look over this
 patch. I agree that I was sloppy in the last patch and the value of
 `parent_id` needs to be consistent everywhere. I'm leaning toward using
 `null` to mean "do nothing" everywhere; passing `false` will be
 interpreted to mean "get the top level groups" just like passing `0` for
 the `parent_id` (`wp_parse_id_list()` converts `false` and `null` to `0`).
 It could just as well be `false` everywhere if that makes more sense to
 you (then `null` would be interpreted as `0`).

 I've updated the patch to be more consistent and added more tests for
 `bp_has_groups()` and for `BP_Groups_Group::get()`.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3961#comment:62>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list