[buddypress-trac] [BuddyPress Trac] #5451: Groups query overhaul

[buddypress-trac]

#5451: Groups query overhaul
--------------------------+------------------
 Reporter:  boonebgorges  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  high          |   Milestone:  2.7
Component:  Groups        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by r-a-y):

 * keywords:  has-patch 2nd-opinion => has-patch


Comment:

 I like the general approach, @boone.  Patch works as advertised!

 A couple of things:
 - This problem only occurs for people who are logged-in that are members
 of the group in the loop:
 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-groups/bp-
 groups-template.php?marks=3245#L3219.  So the query problem isn't that bad
 unless all the groups in the Groups Directory are all yours or if you are
 a member of all of them :)
 - Can we be conservative with the default value of the
 `update_admin_cache` parameter?  We should default to `true` if on the
 Groups Directory or on a user's groups page ( `bp_is_groups_directory() ||
 bp_is_user_groups()` )
 - Likewise, we could also add moderator ID caching, so we can save a query
 on a single group page.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5451#comment:25>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac