[buddypress-trac] [BuddyPress Trac] #6978: Friends: Add caching to BP_Friends_Friendship class

[buddypress-trac]

#6978: Friends: Add caching to BP_Friends_Friendship class
------------------------------------+-----------------------------
 Reporter:  r-a-y                   |       Owner:  dcavins
     Type:  enhancement             |      Status:  accepted
 Priority:  normal                  |   Milestone:  Future Release
Component:  Friends                 |     Version:  1.0
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------------

Comment (by boonebgorges):

 I haven't done a line-by-line review, but the approach here looks good.

 Re `delete_all_for_user()`. It looks like we only use this in core when
 deleting/spamming a user, in which case it's definitely a bug for
 unconfirmed friendships to be left behind. Could you do a search of the
 plugin repo and/or GitHub to see whether there are other uses of it? I can
 imagine possible cases where you'd rely on the current behavior. If you
 can't find anything obvious, go ahead with the change as you've proposed
 it.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6978#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac