[buddypress-trac] [BuddyPress Trac] #5451: Groups query overhaul

[buddypress-trac]

#5451: Groups query overhaul
-----------------------------------+------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  high                   |   Milestone:  2.7
Component:  Groups                 |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------

Comment (by boonebgorges):

 I've found a couple uses of the filters. Only a few in public plugins:

 - Break: https://plugins.trac.wordpress.org/browser/bp-sticky-groups/trunk
 /bp-sticky-groups.php#L254 will break completely. It's @imath's plugin, so
 I assume he'd be happy to accept a patch.
 - OK: https://plugins.trac.wordpress.org/browser/cac-featured-
 content/trunk/cac-featured-autocomplete.php?marks=52-62#L16 will not break
 at all!

 On GitHub (I've excluded anything that I wrote or maintain myself). Many
 of these appear to be copy-paste duplicates of each other:
 - OK:
 https://github.com/misfist/nycga5/blob/d2a02fb311e7a5b5604dd3f3936e1d72a2dd5a2c
 /wp-content/plugins/.temp-bp/ga-group-status/status.php#L40
 - OK:
 https://github.com/ajency/Seedeis/blob/9c6b9198850e0d67a406dfcd4ce18d2d69df55c5
 /wp-
 content/themes/seedeis/business_proposals/Seed_business_proposals.php#L125
 - OK:
 https://github.com/mlaa/levitin/blob/f291f2fa84839fea930cc86b6e8ef945fa461843/lib/mla
 /group-filters.php#L27
 - OK: https://github.com/karysto/cord-
 network/blob/c5c5327e5f5059cb6302fd0209daea9ee422f45a/wp-content/themes
 /cbox-mla-master/bp-custom.php#L72
 - Break: https://github.com/slaFFik/BP-Groups-Extras-
 Search/blob/faf7afdfa1aafcb69dffabd06fa189e40b444edf/bpge-search.php#L180
 - Break: https://github.com/imath/bp-groups-
 taxo/blob/db0f7b6257b2f5e1d1ffe41a737ef9ce9fe15f02/bp-groups/bp-groups-
 tag.php#L180
 - Break: https://github.com/rackdevt/noticeboard-
 master/blob/3355db63535b73617bc74db12e5e981ce9a77312/wp-content/plugins
 /gmw-groups-locator/includes/gmw-gl-component-search-functions.php#L361
 - OK: https://github.com/tamriel-
 foundry/apocrypha/blob/2dd18713f752926199d8d88137892ea1ebbc185f/library/extensions/buddypress.php#L1087
 - Break:
 https://github.com/paulmedwal/edxforumspublic/blob/e77124c8f32c6f092537c748fbb70ace1f2c63a5
 /wp-content/themes/wp-knowledge-base-child/functions.php#L491

 This covers most of the uses I could spot in the wild.

 So, some things will break. It *might* be possible to salvage some of
 these by continuing to assemble the `$sql` array that gets passed to the
 filter, even if it's never used in BP itself; but this will require lots
 of weird code.

 Given the above, I think we're OK to make the change, with associated
 documentation and posts on bpdevel. I'd like to hear what others think
 about that - especially @DJPaul and @r-a-y (@dcavins has already voiced
 his support :) )

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5451#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac