[buddypress-trac] [BuddyPress Trac] #7248: include = [ 0 ] should result in a "no results" query in `BP_User_Query`
buddypress-trac
noreply at wordpress.org
Tue Sep 6 16:15:38 UTC 2016
#7248: include = [ 0 ] should result in a "no results" query in `BP_User_Query`
-----------------------------------+---------------------------
Reporter: boonebgorges | Owner: boonebgorges
Type: defect (bug) | Status: assigned
Priority: high | Milestone: 2.7
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+---------------------------
Changes (by boonebgorges):
* owner: => boonebgorges
* status: new => assigned
Comment:
Thanks, @DJPaul. The good thing about fixing the issue in `BP_User_Query`
is that it'll resolve the problem for `BP_Group_Member_Query` and any
other consumer of `BP_User_Query`. But you're right that a review of other
query classes would be useful.
The non-strict comparison was intentional, in case someone was passing in
`'0'` instead of `0`. If you don't think this is worth checking, it can be
removed, though I have a feeling the loose check will catch more errors.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7248#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list