[buddypress-trac] [BuddyPress Trac] #6978: Friends: Add caching to BP_Friends_Friendship class

[buddypress-trac]

#6978: Friends: Add caching to BP_Friends_Friendship class
--------------------------+-----------------------------
 Reporter:  r-a-y         |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Friends       |     Version:  1.0
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+-----------------------------

Comment (by dcavins):

 Replying to [comment:4 boonebgorges]:
 > @dcavins General approach seems pretty good to me. Does
 [attachment:6978.caching.01.patch] need a refresh after recent changes to
 `bp_get_user_groups()`? See eg [10978], [10977], #7208.
 Do you mean avoiding the use of `wp_list_filter()` as you've done in the
 groups membership functions? That shouldn't be a big deal, since you've
 already developed an approach that works.

 >
 > How much extra work would it be to split friendship queries, so that
 we're doing an ID query and then filling the objects from the cache? (I
 think that's what @r-a-y was originally suggesting.) This would better
 parallel what's happening in other components, and would give performance
 improvements when viewing a single user's profile.
 I don't think it would make it too much more complex. I'll update the
 patch.

 Thanks for taking a look at this!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6978#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac