[buddypress-trac] [BuddyPress Trac] #7239: Wrong naming on Friend component
buddypress-trac
noreply at wordpress.org
Thu Sep 1 17:12:42 UTC 2016
#7239: Wrong naming on Friend component
-------------------------------+------------------
Reporter: espellcaste | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.7
Component: Friends | Version:
Severity: normal | Resolution:
Keywords: reporter-feedback |
-------------------------------+------------------
Comment (by espellcaste):
I think now I got it right! Patch 7239-4 is the correct one. Please,
disregard the others! Those were tests!
@DJPaul @hnla helped me on Slack on the problem.
Regarding the purpose of this ticket:
1st - For me to finally learn to send patches. I'm not a big fan of svn,
neither have I a lot of knowledge of it. But every now and then I postpone
contributing because I need to set a time to learn it.
2nd - I guess the ticket name was poorly formed, but basically I want to
correct this error:
https://github.com/buddypress/BuddyPress/blob/master/src/bp-friends/bp-
friends-loader.php#L20
The PHPDoc name "bp-forums" is in the wrong place, as it is in the friends
component.
Also there are some errors that you can see in the patch.
Also, I'm standardizing the beginning of the PHPDoc to: "Set up the bp-
nameofcomponent component."
And lastly, I'm adding bp_forums_component loader to autoload support.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7239#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list