[buddypress-trac] [BuddyPress Trac] #7296: BuddyPress Private groups showing "Request Membership" Tab to admin/users

[buddypress-trac]

#7296: BuddyPress Private groups showing "Request Membership" Tab to admin/users
--------------------------+-----------------------
 Reporter:  sbrajesh      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  high          |  Milestone:  2.7
Component:  Groups        |    Version:
 Severity:  major         |   Keywords:  has-patch
--------------------------+-----------------------
 With the addition of magical getter/setter in BP_Groups_Group, It is no
 longer possible to add random data on the group object.

 This cause issues with exiting code that dynamically added property on the
 group object. One such issue in the BuddyPress core has cropped up on
 private Groups.

 If you are the admin of the private group and visit it, you will see the
 Request membership navigation link in addition to other links.

 This is happening because the Groups component sets up dynamic property
 'is_user_member' but it is not available due to getters/setters.

 The solution is to modify the definitions of the magical
 methods(__get/__set, __isset) and use an array to store/retrieve random
 property.

 Please find the patch attached.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7296>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac