[buddypress-trac] [BuddyPress Trac] #7226: Update BP_buttons class to accept new arg param for $element_type

buddypress-trac noreply at wordpress.org
Wed Oct 12 00:40:13 UTC 2016


#7226: Update BP_buttons class to accept new arg param for $element_type
-------------------------+---------------------
 Reporter:  hnla         |       Owner:  r-a-y
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:  2.7
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:  fixed
 Keywords:  has-patch    |
-------------------------+---------------------
Changes (by r-a-y):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"11187"]:
 {{{
 #!CommitTicketReference repository="" revision="11187"
 Core: Fix backward compatibility for `BP_Button` class.

 - Set the `$wrapper` property default back to `'div'` as before
 (https://buddypress.trac.wordpress.org/browser/tags/2.6.2/src/bp-
 core/classes/class-bp-button.php?marks=87#L82) and set the
 `$parent_element` property as an empty string as a result.
 - For backward compatiblity, check if property is empty before attempting
 to override mapped property.

 See https://buddypress.trac.wordpress.org/ticket/7226#comment:43

 Props needle, hnla.

 Fixes #7226.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7226#comment:50>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list