[buddypress-trac] [BuddyPress Trac] #7210: Group type frontend integration
buddypress-trac
noreply at wordpress.org
Thu Oct 6 19:21:11 UTC 2016
#7210: Group type frontend integration
-------------------------+--------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.7
Component: Groups | Version: 2.6.0
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+--------------------
Comment (by r-a-y):
> I don't really care what legacy templates do any longer they are dead to
me
Are you referring to the group type directory message or the group type
list function? I don't mind if we make the change to the directory type
message, although the change is quite trivial.
FWIW, `<strong>` vs. `<b>` - https://developer.mozilla.org/en-
US/docs/Web/HTML/Element/strong#Bold_vs._Strong
{{{
strong is a logical state, and bold is a physical state.
Logical states separate presentation from the content, and by doing so
allow for it to be
expressed in many different ways. Perhaps instead of rendering some text
as bold you want
to render it red, or a different size, or underlined, or whatever.
It makes more sense to change the presentational properties of strong than
it does bold.
This is because bold is a physical state; there is no separation of
presentation and content,
and making bold do anything other than bold text would be confusing and
illogical.
}}}
`<strong>` sounds like the correct use here, but I could be wrong.
----
On the other hand, `bp_group_type_list()` is new, so we can make whatever
changes that we need to. Right now, the function was created to output a
comma-delimited list (I guess the function name isn't named appropriately
:) ).
List items are not really appropriate for comma-delimited lists unless you
want to use CSS `:before` and `:after` declarations, which complicates
things.
I guess it all depends on what you want to do with the function. If you
plan on using this function for list items, then the function needs to be
tweaked to accommodate it.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7210#comment:36>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list