[buddypress-trac] [BuddyPress Trac] #7210: Group type frontend integration

[buddypress-trac]

#7210: Group type frontend integration
-------------------------+--------------------
 Reporter:  r-a-y        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.7
Component:  Groups       |     Version:  2.6.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+--------------------

Comment (by r-a-y):

 @hnla - Thanks for the feedback.

 > My pressing concern is that I do think the creation step initial screen
 must house the Name, Descrip, and type as the three fundamental pieces of
 info before we create a group_id then checks on the other steps can be
 made to bail out of custom group steps more easily or adjust subsequent
 step screens.

 I would consider the group privacy option more pressing than the group
 type.  Group privacy is also listed on the second step as well.

 Would welcome other feedback here, but I think we need another cycle to
 re-evaluate all the other group options during the group creation phase.

 > I noticed that we're wrapping the
 bp_get_current_group_directory_type_message() markup group type slug in a
 pair of <strong> elements

 For `bp_get_current_group_directory_type_message()`, current markup was
 lifted from the member type directory's message:
 https://buddypress.trac.wordpress.org/browser/tags/2.6.2/src/bp-members
 /bp-members-template.php?marks=1969#L1959

 So if we change this here, we'd need to change it for member types as
 well.

 > bp_group_type_list The <strong> element might be better served and the
 cdata as something like a dl list as we're possibly running a few items in
 a list.

 The W3C says the following about lists and groups of links
 [https://www.w3.org/TR/WCAG20-TECHS/H48.html here]:


 {{{
 The objective of this technique is to create lists of related items using
 list elements
 appropriate for their purposes. The ol element is used when the list is
 ordered and the
 ul element is used when the list is unordered. Definition lists (dl) are
 used to group
 terms with their definitions.

 Although the use of this markup can make lists more readable, not all
 lists need markup.
 For instance, sentences that contain comma-separated lists may not need
 list markup.
 }}}

 I think the last block applies to us here.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7210#comment:33>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac