[buddypress-trac] [BuddyPress Trac] #7318: Cleanup incorrect remove_action() & remove_filter() usage

buddypress-trac noreply at wordpress.org
Mon Nov 28 21:27:38 UTC 2016


#7318: Cleanup incorrect remove_action() & remove_filter() usage
----------------------------------------------------+------------------
 Reporter:  slaFFik                                 |       Owner:
     Type:  defect (bug)                            |      Status:  new
 Priority:  low                                     |   Milestone:  2.8
Component:  Core                                    |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  good-first-bug needs-refresh has-patch  |
----------------------------------------------------+------------------
Changes (by slaFFik):

 * keywords:  good-first-bug has-patch => good-first-bug needs-refresh has-
     patch


Comment:

 @ketuchetan
 I checked your patch and saw that you missed several `remove_action()` and
 `remove_filter()` calls. On a first glance (actually, search in PhpStorm)
 I noticed 4 results:


 {{{
 remove_action( 'bp_send_email_success',
 'bp_core_deprecated_email_actions', 20, 2 );
 remove_action( 'bp_user_query_populate_extras', array( $this,
 'populate_group_member_extras' ), 10, 2 );
 remove_filter( 'bp_get_group_type_directory_permalink', array( $this,
 'group_type_permalink_use_admin_filter' ), 10, 2 );
 remove_filter( "bp_get_options_nav_{$css_id}",
 'bp_group_admin_tabs_backcompat', 10, 3 );
 }}}

 Can you please update them too?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7318#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list