[buddypress-trac] [BuddyPress Trac] #7314: Buddypress issue with Twenty Sixteen menu

buddypress-trac noreply at wordpress.org
Mon Nov 28 12:25:06 UTC 2016

#7314: Buddypress issue with Twenty Sixteen menu
 Reporter:  DarkWolf      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.7.3
Component:  Templates     |     Version:  2.7
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |

Comment (by DJPaul):

 I think that is the wrong approach.

 9--> 2017 has `no-js` in its template, and removes it if JS is present in
 its `twentyseventeen_javascript_detection()` (hooked to `wp_head` at
 priority 0), which will run pretty soon after page load. It's VERY near
 the top of the page.

 --> BP adds `no-js` via `body_class` and removes it in our buddypress.js,
 inside a jQuery `ready` callback. (i.e. much later than 2017's).

 I don't understand really what the problem is. Even if the theme
 temporarily thought it had no JS support, it ought to "flash back" with JS
 features appearing, after DOM Ready... right? I don't understand why this
 isn't happening. I'm going to assume it's because of some quirk of load
 order and timing. (confused!)

 At any rate, we could basically just copy/paste the JS in
 `twentyseventeen_javascript_detection()` into the VERY top of our
 buddypress.js, which means that our `no-js` will be removed much quicker
 than it is. Can someone who knows how to recreate this problem, test the
 approach? Or maybe talk me through it on Slack sometime so I can learn.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7314#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list