[buddypress-trac] [BuddyPress Trac] #7318: Cleanup incorrect remove_action() & remove_filter() usage

buddypress-trac noreply at wordpress.org
Sat Nov 26 15:51:21 UTC 2016


#7318: Cleanup incorrect remove_action() & remove_filter() usage
----------------------------------------------------+------------------
 Reporter:  slaFFik                                 |       Owner:
     Type:  defect (bug)                            |      Status:  new
 Priority:  low                                     |   Milestone:  2.8
Component:  Core                                    |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  good-first-bug needs-refresh has-patch  |
----------------------------------------------------+------------------
Changes (by slaFFik):

 * keywords:  good-first-bug has-patch => good-first-bug needs-refresh has-
     patch


Comment:

 @ketuchetan
 Thanks for the patch!

 Could you please make sure that you are not modifying a 3rd-party plugin,
 bundled with BuddyPress - bp-forums? It's an external source of code, and
 should not be directly modified.

 Also, would be really nice to have the patch created from the root
 directory of the repository, that means that all paths to BuddyPress PHP
 files should be with `/src/` and the beginning. Currently you created a
 patch from inside of `/build/` directory.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7318#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list