[buddypress-trac] [BuddyPress Trac] #7345: Clean up BP_Core_Nav_Item

[buddypress-trac]

#7345: Clean up BP_Core_Nav_Item
-------------------------+--------------------
 Reporter:  slaFFik      |       Owner:  imath
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.8
Component:  Navigation   |     Version:  2.6.0
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+--------------------
Description changed by slaFFik:

Old description:

> As we are moving to PHP 5.3, we can deprecated some code.
> Regarding `BP_Core_Nav_Item` - `bp-core/classes/class-bp-core-nav-
> item.php`
>
> It has an if statement to use `ArrayObject` which was introduced in PHP
> 5.3, so we can remove its `else` statement for BuddyPress 2.8.
>
> See attached patch, where I also cleaned up BP_Nav_Item =>
> BP_Core_Nav_Item mentions in code comments.

New description:

 As we are moving to PHP 5.3, we can deprecate some code.
 Regarding `BP_Core_Nav_Item` - `bp-core/classes/class-bp-core-nav-
 item.php`

 It has an if statement to use `ArrayObject` which was introduced in PHP
 5.3, so we can remove its `else` statement for BuddyPress 2.8.

 See attached patch, where I also cleaned up BP_Nav_Item =>
 BP_Core_Nav_Item mentions in code comments.

--

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7345#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac