[buddypress-trac] [BuddyPress Trac] #7331: display_comments=stream for bp_has_activities() doesn't work

[buddypress-trac]

#7331: display_comments=stream for bp_has_activities() doesn't work
-------------------------------------+------------------
 Reporter:  slaFFik                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  2.8
Component:  Activity                 |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |
-------------------------------------+------------------
Changes (by slaFFik):

 * keywords:  needs-patch => needs-patch 2nd-opinion


Comment:

 2nd (main) reason, why this doesn't work properly - replies to comments
 are stored with `component=activity` and not `groups` (as parent). So
 leaving a reply to a group activity makes this reply non-group compliant.
 Generated SQL:

 {{{
 SELECT DISTINCT a.id
 FROM wp_bp_activity a
 WHERE a.component IN ( 'groups' )
   AND a.item_id IN ( 23 )
   AND a.is_spam = 0
 ORDER BY a.date_recorded DESC, a.id DESC
 LIMIT 0, 21
 }}}

 IMO we need to fix this and use component of the parent item when saving
 reply to an activity.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7331#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac