[buddypress-trac] [BuddyPress Trac] #7308: Make function "bp_core_menu_highlight_parent_page" multisite-aware

[buddypress-trac]

#7308: Make function "bp_core_menu_highlight_parent_page" multisite-aware
----------------------------------------+------------------
 Reporter:  martinutopia                |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  2.8
Component:  Core                        |     Version:  2.7
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |
----------------------------------------+------------------
Changes (by DJPaul):

 * keywords:   => good-first-bug needs-patch
 * milestone:  Awaiting Review => 2.8


Comment:

 Hi @martinutopia

 Thanks for the bug report (your first, I think; welcome!).

 I think we'll fix this with our `bp_is_root_blog` function rather than
 `ms_is_switched` (the latter function is only present if multisite is
 enabled). Alternately, BuddyPress could do its own `switch_to_blog` inside
 the function. I need to spend more than 5 minutes considering the best fix
 to be sure, but we can definitely get this in for our next major release
 (2.8; early next year).

 For now, I'd suggest you hook a function to that action with a higher
 priority, and inside that function callback, unhook the BuddyPress
 function from that action if `ms_is_switched` since that apparently works
 well for you.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7308#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac