[buddypress-trac] [BuddyPress Trac] #4824: Autocomplete

[buddypress-trac]

#4824: Autocomplete
------------------------------------------+-----------------------
 Reporter:  stefwilliams                  |       Owner:
     Type:  defect (bug)                  |      Status:  reopened
 Priority:  normal                        |   Milestone:  2.6
Component:  Component - Messaging         |     Version:  2.5.0
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch 2nd-opinion commit  |
------------------------------------------+-----------------------
Changes (by imath):

 * keywords:  has-patch 2nd-opinion => has-patch 2nd-opinion commit


Comment:

 I agree with boonebgorges. Just tested the patch and it's fixing the
 issue.

 @DJPaul i understand your point
 > I am generally against modifying third party scripts

 Problem is we already modified the two scripts!

 For instance i doubt that at line 362 of jquery.autocomplete.js that
 {{{
 jQuery('#send-to-input').removeClass('loading');
 }}}
 was there in original version of the script.

 And in jquery.autocompletefb.js i'm sure that this part is not into the
 original script
 {{{
 foundClass : ".friend-tab",
 inputClass : ".send-to-input"
 }}}

 So i'm in favor of committing 4824.diff.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4824#comment:17>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac