[buddypress-trac] [BuddyPress Trac] #5757: Add a "data-timestamp" attribute to all templates requiring timestamps

buddypress-trac noreply at wordpress.org
Wed May 25 18:18:16 UTC 2016

#5757: Add a "data-timestamp" attribute to all templates requiring timestamps
 Reporter:  r-a-y                   |       Owner:  r-a-y
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.6
Component:  Component - Core        |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |

Comment (by r-a-y):

 > NB: if i've suggested the use of this function for the activity embed
 ticket that's because, the activity embeds are requiring WP 4.5

 Argh, good catch, imath!

 I wasn't sure if we wanted to go with an external JS file or an inline
 one.  For `02.patch`, I opted for inline and added some backpat support
 for < WP 4.5.


 > The only question I have about it is that the time strings output by the
 JS library are not the same as we currently generate

 I also encountered something similar as the localization is the missing

 eg. `active 5 seconds ago` becomes `5 seconds ago`.

 For our widgets that use `created X ago` or `active X ago`, this becomes a
 little problematic.

 Is this a dealbreaker?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5757#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list