[buddypress-trac] [BuddyPress Trac] #5757: Add a "data-timestamp" attribute to all templates requiring timestamps

buddypress-trac noreply at wordpress.org
Tue May 24 20:14:06 UTC 2016


#5757: Add a "data-timestamp" attribute to all templates requiring timestamps
------------------------------------+-----------------------
 Reporter:  r-a-y                   |       Owner:  r-a-y
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.6
Component:  Component - Core        |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------
Changes (by dcavins):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 This is great. The only question I have about it is that the time strings
 output by the JS library are not the same as we currently generate:
 "1 week, 4 days ago" becomes "12 days ago"
 "3 weeks, 3 days ago" becomes "25 days ago"
 "3 months, 1 week ago" becomes "3 months ago"
 "7 months, 4 weeks ago" becomes "8 months ago"

 It appears, from the localization file, that the JS library uses the
 increments:
 a few seconds ago (less than a minute)
 ## minutes (up to an hour)
 ## hours (up to a day)
 ## days (up to a month)
 ## months (up to a year)
 ## years

 It suits me, but are we OK with this change? (Devs can always have the old
 strings back by dequeueing the js files.)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5757#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list